fair-weather friend

A friend who is faithful in good times but fails you in time of trouble. It is the opposite of a FRIEND IN NEED IS A FRIEND INDEED.
The transfer of “fair weather” to “good times” presumably occurred long
before, but the adjectival application to a friend of dubious loyalty did not
take place until the early eighteenth century.